cloud service cleanup (auth mostly) #4539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
adamhill
reviewed
Jun 11, 2025
| extension: { | ||
| packageJSON: { | ||
| version: "1.0.0", | ||
| publisher: "RooVeterinaryInc", |
Contributor
There was a problem hiding this comment.
Did you mean to continue to use the old name here?
Collaborator
Author
There was a problem hiding this comment.
That actually still is the value in that field (see
Line 5 in e1c48f0
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
- Use zod schemas to validate responses - Switch to fetch() from axios - Remove unused session token parsing from sign in - Clear credentials (and logout) if session token response indicates invalid/expired client token - Add AuthService unit tests
cte
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove singleton logic from internal cloud services
Cloud: cleanup AuthService
invalid/expired client token
Important
Refactor
AuthService,CloudService, andSettingsServiceto improve authentication handling, replaceaxioswithfetch, and add unit tests.axioswithfetchfor HTTP requests.AuthService.ts.AuthService.InvalidClientTokenErrorto handle invalid/expired tokens.AuthService.spec.ts.CloudService.AuthServiceandSettingsServiceconstructors.SettingsService.AuthServiceconstructor.vscodemock in__mocks__/vscode.tsto includeonDidChangemethod.CloudServiceinCloudService.test.ts.This description was created by
for 1df0fa6. You can customize this summary. It will automatically update as commits are pushed.